-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Joomla 3.9.10 merge #26108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joomla 3.9.10 merge #26108
Conversation
wilsonge
commented
Aug 31, 2019
- Merge with a merge not a squash/rebase
* Media field style and layout * Small screen considerations * Tweaks * Revert js change * indent * Fix scroll in chrome
Chosen is not accessible so we shouldnt use it unless it offers something useful. In the search component in the front end there are potentially two lists Ordering and display # Neither of these require or benefit from chosen so this simple PR returns them to regular and accessible lists
The $key parameter can be either an array or a string but from PHPDoc it was only an array
* Improvements to mediamanager.js and popup-imagemanager.js - use jquery's prop function instead of attr - properly and consistently encode and decode URI components - explicitly use global variables from the global scope * Wait till the iframe is loaded before doing things that required the iframe to be loaded.
…k on Plus (+) button to add repeated subform joomla#25387 (joomla#25398)
…oomla#25406) Pinned sodium_compat because of file case change, atm this could not be handled by the Joomla! updater.
Joomla! 3.9.10
|
Known failure case trying to login into the admin site. So choosing to merge this with the failing test. Tests passed in mysql suggesting that the system tests are largely working and the only postgres changes here relate to template styles EDIT: PostgreSQL passed on the merge commit drone run - so this was indeed just a blip |
| name="fieldfilter" | ||
| type="list" | ||
| label="PLG_FIELDS_TEXT_PARAMS_FILTER_LABEL" | ||
| description="PLG_FIELDS_TEXT_PARAMS_FILTER_DESC" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this language string is not present in j4 because we removed the usage of the description
|
you merged as I was typing an issue. do you want me to submit a pr or will you add to the commit |
|
Sorry - can you do a PR please. Just saw this and about to head to bed. |
|
done #26112 |